Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FLAC VORBIS_COMMENT block in metadata #5527

Closed
nlgtuankiet opened this issue Feb 18, 2019 · 6 comments
Closed

Expose FLAC VORBIS_COMMENT block in metadata #5527

nlgtuankiet opened this issue Feb 18, 2019 · 6 comments
Assignees

Comments

@nlgtuankiet
Copy link

Is there a way to pull out .flac file metadata (title, album name...)? I tried the EventLogger in the sample app, It work for .mp3 .m4a but not for .flac. I believe the default FlacExtractor already enable peekId3Data.
Not sure this feature is implemented or not.

@andrewlewis andrewlewis self-assigned this Feb 20, 2019
@andrewlewis
Copy link
Collaborator

If it's stored as ID3 data at the start of the file and isn't disabled via FLAG_DISABLE_ID3_METADATA this should work. If you provide the media you're trying to play we'll take a look (see the issue template).

@nlgtuankiet
Copy link
Author

Sure, I have tried to retrieve the title with MediaMetadataRetriever, it works, so it definitely in there, I just don't know the proper way to get it
Muon Ruou To Tinh.zip

@andrewlewis
Copy link
Collaborator

This stream does not have an ID3 prefix, but after the STREAMINFO block at the start there is a PICTURE block and a VORBIS_COMMENT block. The latter has a title and artist, but I don't think we're parsing it at the moment. (It looks like we only handle STREAMINFO and SEEKTABLE in our libflac wrapper.)

I will mark this as a enhancement to store the vorbis comment payload in the metadata but it's low priority for now. I think we'd also be happy to accept a pull request for this.

@szaboa
Copy link
Contributor

szaboa commented Jul 1, 2019

@ojw28
I'd like to solve this, if there is no ongoing work on this currently.

@ojw28
Copy link
Contributor

ojw28 commented Jul 1, 2019

This is being worked on already, I think by @vavadhani or one of his colleagues. We expect support to be added soon.

@ojw28 ojw28 removed the low priority label Jul 1, 2019
@szaboa
Copy link
Contributor

szaboa commented Jul 1, 2019

Alright, then I will search for something else :)

vavadhani added a commit to ittiam-systems/ExoPlayer that referenced this issue Jul 9, 2019
Decode and add vorbis comments from the flac file to metadata.

 google#5527
@ojw28 ojw28 closed this as completed Jul 14, 2019
@google google locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants