-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When playing wav file on MTK device, just sounds only noisy #5782
Comments
I don't understand the request, since the fix for the issue you refer to is not targeted at specific devices. The fix was to always prefer the Google decoder over the MTK decoder on all devices running pre-O Android versions. Please can you provide complete information by properly filling out the issue template, to help us investigate this further? Please copy the issue template into this issue (do not file a new one) and fill out all of the sections. Thanks! |
@isuperqiang - Please update this issue. |
[REQUIRED] Issue descriptionCan't play wav file on some devices. [REQUIRED] Reproduction stepsSet data source by local wav file, then it sounds noisy on Oppo R9tm. But plays well on other devices. [REQUIRED] Link to test contentA normal wav file. [REQUIRED] A full bug report captured from the device
[REQUIRED] Version of ExoPlayer being used2.9.6 [REQUIRED] Device(s) and version(s) of Android being usedOppo R9tm, Android 5.1 |
I fixed it by the following code. Is this OK?
|
I still don't understand what this is fixing, because our code already seems to prefer Which sorts raw decoders: To prefer the Google decoder and explicitly de-prioritize the MTK one: @isuperqiang - Please could you clarify why the code referenced above isn't already doing what you're trying to do? |
Yes, I see it. But |
@isuperqiang Please could you attach the output of |
@andrewlewis This is
|
Issue: #5782 PiperOrigin-RevId: 247934223
See previous issue, I found Oppo R9(Android 5.1) is MTK device, so please add it to MediaCodecUtil#isCodecUsableDecoder(). Thanks.
The text was updated successfully, but these errors were encountered: