Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMA extension having issues when loading tags with mid-rolls but no pre-rolls #5928

Closed
foodpoison opened this issue May 22, 2019 · 2 comments
Assignees
Labels

Comments

@foodpoison
Copy link

foodpoison commented May 22, 2019

[REQUIRED] Issue description

When loading tags that have mid-rolls but no pre-rolls, playback can get stuck:

  1. Playing video with no pre-roll from the beginning, starts fine, but once we get to and play past the first mid-roll, it can get stuck in what seems like an endless loop and can't get out.
  2. Playing video with no pre-roll from position between first mid-roll and second mid-roll directly (by seekTo() before prepare()), just gets stuck, sometimes doesn't even play the first mid-roll with snapback.

If we use a video with pre-rolls with the above conditions, everything would seem to work like normal.

[REQUIRED] Reproduction steps

I have made a forked branch that illustrates this issue: https://github.com/foodpoison/ExoPlayer/tree/tweak/failing_conditions_when_no_prerolls
In the demo-ima's PlayerManager, I've setup a couple of flags that you can use to toggle between the conditions, also drew an ASCII chart of the working/failing conditions in as comments. Current GET_PREROLL_ADS is set to true, which should work OK; change it to false and you'll go into the first failing situation. Filter logcat with word ImaAdsLoader.

NOTE: please VPN to Malaysia for the Ads to work, sorry I don't have control over them, perhaps you guys have more resources to replicate their settings to get something that would work for you

[REQUIRED] Link to test content

The forked branch above had been updated with test contents.

[REQUIRED] A full bug report captured from the device

bugreport-2019-05-23-10-55-26.zip

[REQUIRED] Version of ExoPlayer being used

ExoPlayer - r2.10.1 and r2.9.6, combined with IMA 3.11.2 and 3.10.9 respectively, had been tested to have this issue.

[REQUIRED] Device(s) and version(s) of Android being used

Using the demo app branch I provided above, and if the Ads are loading properly (VPN could slow network down, so increased the timeouts in the code) it was pretty easy to reproduce, my current dev device is Samsung J7 Prime (Android 8.1.0), but also reports from my company's QA team's all their test devices have shown this issue, which covers a decent version range.

@foodpoison
Copy link
Author

Fix to this issue PR #5998 , please review :)

ojw28 pushed a commit that referenced this issue Jun 21, 2019
@ojw28 ojw28 closed this as completed Jun 21, 2019
@ojw28
Copy link
Contributor

ojw28 commented Jun 21, 2019

@foodpoison - Thanks very much for your help on this!

ojw28 pushed a commit that referenced this issue Jun 21, 2019
@google google locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants