Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG G5: No sound when playing ALAC audio track #5938

Closed
gemiren opened this issue May 24, 2019 · 5 comments
Closed

LG G5: No sound when playing ALAC audio track #5938

gemiren opened this issue May 24, 2019 · 5 comments

Comments

@gemiren
Copy link

gemiren commented May 24, 2019

[REQUIRED] Content description

The m4a file loads in ExoPlayer without any error. The time bar even progresses normally when it plays but no sound comes out.

[REQUIRED] Link to test content

http://feeds.soundcloud.com/stream/624159534-the-stemma-report-ep05.m4a

[REQUIRED] Version of ExoPlayer being used

2.10.1

[REQUIRED] Device(s) and version(s) of Android being used

Pixel 3 Android P

@marcbaechinger
Copy link
Contributor

The m4a stream you posted does contain an ALAC file. The device doesn't have a decoder for this so the track can't be played with the default renderer. When I add the uri to the demo app it gives me the following output:

D/EventLogger: tracksChanged [2.90, 0.00, window=0, period=0, 
D/EventLogger:   Renderer:1 [
D/EventLogger:     Group:0, adaptive_supported=N/A [
D/EventLogger:       [ ] Track:0, id=1, mimeType=audio/alac, channels=2, sample_rate=44100, language=```, supported=NO_UNSUPPORTED_TYPE
D/EventLogger:     ]
D/EventLogger:   ]
D/EventLogger: ]

If you want to play files of that format with ExoPlayer you need to use the ffmpeg extension.

@gemiren
Copy link
Author

gemiren commented May 28, 2019

Well, the android.media.MediaPlayer can play that m4a file without any issue. I'd expect ExoPlayer to play it without the ffmpeg extension since android.media.MediaPlayer can play it.

@marcbaechinger
Copy link
Contributor

I did not manage to play the file on a Pixel 3 with P. Can you give me some details how you did this?

@gemiren
Copy link
Author

gemiren commented May 29, 2019

I'm sorry. I should clarify that I was able to play that file using MediaPlayer on my LG G5 phone. However, ExoPlayer still fails to paly it on LG G5.

And you are right that it failed to play with both MediaPlayer and ExoPlayer on Pixel 3.

@ojw28 ojw28 changed the title No sound when playing m4a file LG G5: No sound when playing ALAC audio track Jun 21, 2019
ojw28 pushed a commit that referenced this issue Aug 1, 2019
ojw28 added a commit that referenced this issue Aug 1, 2019
Android considers ALAC initialization data to consider of the magic
cookie only, where-as FFmpeg requires a full atom. Standardize around
the Android definition, since it makes more sense (the magic cookie
being contained within an atom is container specific, where-as the
decoder shouldn't care what container the media stream is carried in)

Issue: #5938
PiperOrigin-RevId: 261124155
ojw28 added a commit that referenced this issue Aug 1, 2019
Issue: #5938
PiperOrigin-RevId: 261150349
@ojw28
Copy link
Contributor

ojw28 commented Aug 1, 2019

Fixed in the dev-v2 branch. The fix will be included in the 2.10.4 release.

@ojw28 ojw28 closed this as completed Aug 1, 2019
ojw28 pushed a commit that referenced this issue Aug 1, 2019
ojw28 added a commit that referenced this issue Aug 1, 2019
Android considers ALAC initialization data to consider of the magic
cookie only, where-as FFmpeg requires a full atom. Standardize around
the Android definition, since it makes more sense (the magic cookie
being contained within an atom is container specific, where-as the
decoder shouldn't care what container the media stream is carried in)

Issue: #5938
PiperOrigin-RevId: 261124155
ojw28 added a commit that referenced this issue Aug 1, 2019
Issue: #5938
PiperOrigin-RevId: 261150349
@google google locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants