Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadErrorHandlingPolicy in DefaultDrmSession/DefaultDrmSessionManager #6334

Closed
kgrevehagen opened this issue Aug 23, 2019 · 2 comments
Closed
Assignees

Comments

@kgrevehagen
Copy link

Use case description

I don't want to retry 4xx errors for the DRM license key requests, but 5xx errors I would like to retry with exponential backoff, just as it is already done inside DefaultDrmSession.

Proposed solution

Inject a LoadErrorHandlingPolicy to DefaultDrmSession via DefaultDrmSessionManager, similarly to how initialDrmRequestRetryCount is added.

Alternatives considered

  • Write own implementation of DrmSession and DrmSessionManager, but I don't want to duplicate all of this logic into my own classes just to change one private method.
  • Set initialDrmRequestRetryCount to 0 and handle it myself inside an implementation of MediaDrmCallback, but this feels kinda backwards.
@AquilesCanta
Copy link
Contributor

This should be available in the next release. A commit reference will appear in this issue once the change is pushed to the dev-branch. Once that happens, please give it a try and reach back if you encounter any issues.

ojw28 pushed a commit that referenced this issue Aug 30, 2019
This is a no-op interim change to introduce key request error
handling customization. Following changes will allow users to
inject their own LoadErrorHandlingPolicy implementations.

Issue:#6334
PiperOrigin-RevId: 266344399
@ojw28 ojw28 closed this as completed Sep 2, 2019
@AquilesCanta AquilesCanta reopened this Sep 2, 2019
@AquilesCanta
Copy link
Contributor

We still need to allow custom implementations.

tonihei pushed a commit that referenced this issue Sep 5, 2019
@tonihei tonihei closed this as completed Sep 5, 2019
@AquilesCanta AquilesCanta reopened this Sep 5, 2019
ojw28 pushed a commit that referenced this issue Sep 17, 2019
Issue:#6334
PiperOrigin-RevId: 269553308
ojw28 pushed a commit that referenced this issue Oct 2, 2019
Issue:#6334
Issue:#4721
Issue:#6334
Issue:#4867
PiperOrigin-RevId: 271577773
@google google locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants