-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @NullableType annotations to be compatible with Kotlin #6792
Comments
Thanks for reporting. We'll fix the MediaClock problem. The RendererConfigurations and TrackSelections in the second example are a problem though because they use the deprecated |
While we are trying to figure out how to solve the
|
The fix for |
thanks for your help |
1 similar comment
thanks for your help |
another kotlin error
but, This can lead to exceptions in the kotlin language
|
The existing NullableType has been deprecated 5 years ago and causes crashes in Kotlin apps because Kotlin doesn't recognize this annotation as a nullable type annotation. While we can't align on a single @nullable annotation yet, we can at least replace this one by JSR305's @nonnull(MAYBE) as it fulfils all requirements, including full Kotlin compatiblity. To avoid the cumbersome name, we can redefine it as our own @nullabletype annotation. (We can't use @nullable to avoid name clashes with the main @nullable annotation from AndroidX) Issue: google/ExoPlayer#6792 PiperOrigin-RevId: 540497469
The existing NullableType has been deprecated 5 years ago and causes crashes in Kotlin apps because Kotlin doesn't recognize this annotation as a nullable type annotation. While we can't align on a single @nullable annotation yet, we can at least replace this one by JSR305's @nonnull(MAYBE) as it fulfils all requirements, including full Kotlin compatiblity. To avoid the cumbersome name, we can redefine it as our own @nullabletype annotation. (We can't use @nullable to avoid name clashes with the main @nullable annotation from AndroidX) Issue: #6792 PiperOrigin-RevId: 540497469
return type can be null, but I got compile error
I think it's right to pass arrayOfNull
The text was updated successfully, but these errors were encountered: