Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TTML extent & origin on <p> & <div> tags #6978

Open
icbaker opened this issue Feb 14, 2020 · 2 comments
Open

Support TTML extent & origin on <p> & <div> tags #6978

icbaker opened this issue Feb 14, 2020 · 2 comments
Assignees

Comments

@icbaker
Copy link
Collaborator

icbaker commented Feb 14, 2020

Use case description

TTML2 allows origin and extent to be declared on <p> and <div> tags:
https://www.w3.org/TR/2018/REC-ttml2-20181108/#style-attribute-extent-special-usage

Currently TtmlDecoder only parses extent & origin from region tags (TTML 1 only allowed this):

String regionOrigin = XmlPullParserUtil.getAttributeValue(xmlParser, TtmlNode.ATTR_TTS_ORIGIN);

Proposed solution

Update TtmlDecoder#parseNode to consider tts:origin and tts:extent attributes.

@icbaker icbaker self-assigned this Feb 14, 2020
@nigelmegitt
Copy link

Worth noting that usage of this feature (TTML2's #region-implied-animation feature) is not permitted in either the IMSC or EBU-TT-D profiles, when considering prioritisation of this vs other features that have a bigger impact for the user such as #linePadding - I know this is a bit cheeky because there's no issue open for supporting linePadding, but in general it would be worth prioritising features that are in the IMSC profiles over those that aren't, IMO.

ojw28 added a commit that referenced this issue Jun 29, 2020
Issue: Issue: #6978
PiperOrigin-RevId: 318710782
@ojw28
Copy link
Contributor

ojw28 commented Jun 29, 2020

Ignore the commit referenced above; the commit referenced the wrong issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants