-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A warning occurs when applying proguard from version 2.12.0. #8103
Comments
I don't see the warnings you mention when compiling the demo app at 2.12.0:
Without being able to reproduce the problem it's very hard to determine where it's coming from. Please provide a minimal reproducible example that demonstrates the problem in a way that we can build locally. This could be an Android Studio project on GitHub, or zipped up and sent to dev.exoplayer@gmail.com using a subject in the format "Issue #1234", where "#1234" should be replaced with your issue number. Please also update this issue to indicate you’ve done this. |
I made a sample
And you can see that there are no errors if you change the version to 2.11.8 and repeat again. Thx |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
OK, trying again :) Thanks for the project, I can repro with your instructions. I can also repro in the demo app by adding
So the error only seems to occur when using ProGuard instead of R8. Note that
I think this is related to some dependencies that Guava pulls in and only uses at compile-time. We deliberately exclude these here: ExoPlayer/library/common/build.gradle Lines 19 to 27 in 5b1514e
We already |
Without these lines, ProGuard fails on the demo app (R8 works). Also include some more `-dontwarn` lines from https://github.com/google/guava/wiki/UsingProGuardWithGuava #minor-release Issue: #8103 PiperOrigin-RevId: 339050634
Without these lines, ProGuard fails on the demo app (R8 works). Also include some more `-dontwarn` lines from https://github.com/google/guava/wiki/UsingProGuardWithGuava Issue: #8103 PiperOrigin-RevId: 339050634
A warning occurs when applying proguard from version 2.12.0. (2.12.1 is equal)
My dependencies are below.
During build, the following error occurs.
What should I apply to ProGuard?
The text was updated successfully, but these errors were encountered: