-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not play midroll #8428
Comments
Hi @andrewlewis , could you take a look? |
looks like duplicate of #8349 |
Thanks for reporting. Just after we report the seek position to the IMA SDK we get |
The IMA SDK currently notifies `CONTENT_RESUME_REQUESTED` then `CONTENT_PAUSE_REQUESTED` quickly afterwards when playing an ad for an initial seek. This triggered the logic to skip VPAID ads added for Issue: #7832, causing the ad to be skipped. This change reverts the fix for that issue and extends the ad preload timeout logic to cover the case of an initial seek as well. Incompatible VPAID ads will still be skipped but only after the preload delay (this seems fine given that they are documented not to be supported, and we are just making the failure mode less bad on a best-effort basis!). Issue: #8428 Issue: #7832 PiperOrigin-RevId: 353011270
[REQUIRED] Issue description
[REQUIRED] Reproduction steps
3.Can not play mid-roll
Here is the ImaAdsLoader debug log
2021-01-05 14:27:56.798 11876-11876/com.google.android.exoplayer2.demo W/ImaAdsLoader: onEnded without ad media info
2021-01-05 14:28:07.457 11876-11876/com.google.android.exoplayer2.demo I/ImaAdsLoader: AdEvent: {errorMessage=VAST media file loading reached a timeout of 8 seconds., errorCode=402, type=adPlayError}
[REQUIRED] Version of ExoPlayer being used
2.12.2
[REQUIRED] Device(s) and version(s) of Android being used
Samsung Galaxy S10, Android 10
The text was updated successfully, but these errors were encountered: