Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exoplayer does not complete playback when postroll ad tag is returning empty vast #8431

Closed
krackjack234 opened this issue Jan 6, 2021 · 8 comments
Assignees

Comments

@krackjack234
Copy link

krackjack234 commented Jan 6, 2021

We are seeing a problem with Exoplayer 2.12.0 where the player is getting stuck and not reporting STATE_ENDED event when the postroll ad tag returns empty vast

We haved shared the sample Exoplayer test app with client ad tag privately to dev.exoplayer@gmail.com

In the Exoplayer demo app we can see the problem by using the following steps:

Try the option IMA sample ad tags- > Single inline linear to see the issue. You will notice that on reaching the end of playback, the sample player goes into buffering and doesnot report end of playback

  • ExoPlayer version number: 2.12.0
  • Android version: All
  • Android device: All
@krackjack234
Copy link
Author

Hi @andrewlewis, did you get a chance to look into this?

@andrewlewis
Copy link
Collaborator

In the ExoPlayer demo app on dev-v2 the ad tag provided via email plays to the end and the player transitions to STATE_ENDED, but the postroll ad was not empty.

Please could you check whether this issue reproduces for you using dev-v2 preferably in the ExoPlayer demo app, and, if so, supply the logs output when reproducing the error, with debug logs enabled viaImaAdsLoader.Builder.setDebugModeEnabled(true) when building the ImaAdsLoader? Please send the logs via email to dev.exoplayer@gmail.com with subject line 'Issue #8431' and reply here once you've done that so we can take a look. Thanks.

@andrewlewis
Copy link
Collaborator

For what it's worth, I also tested with this test ad tag, which has a midroll and an empty postroll, and playback ended as expected.

@krackjack234
Copy link
Author

krackjack234 commented Jan 13, 2021

hi @andrewlewis we have shared a new ad tag over mail where we could reproduce the issue. The issue seems to happen when we seek over midroll cue points and both the midroll and postroll return empty vast. Issue is seen after IMAAdsLoader reports a LOG and then an AD_BREAK_FETCH error event.

We have also shared IMA logs for this scenario.

Do let us know if you want us to check in any of the dev releases.

Thanks

@andrewlewis
Copy link
Collaborator

I tried using the new ad tag provided via email but I didn't see any empty ad breaks and couldn't reproduce the issue.

I suspect you may be seeing the same bug as #8205, which was fixed in 2.12.3. Please could you try that release?

@krackjack234
Copy link
Author

Hi @andrewlewis , we checked the same ad tag with Exoplayer v2.12.3 but we still see the issue.
We have shared the attached logs over mail. We dont see any STATE_ENDED event coming if we scrub across multiple cuepoints where all cuepoints returns empty vast.

@andrewlewis
Copy link
Collaborator

It looks like the ad tag has cue points after the duration of the content (there is a cue point at one hour, but the emailed logs show a duration of about 20 minutes). I'm afraid this is currently not supported. See #5534 for more information.

@andrewlewis
Copy link
Collaborator

Duplicate of #5534

@andrewlewis andrewlewis marked this as a duplicate of #5534 Jan 25, 2021
@google google locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants