-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need a way to decide if the Skip Button should be focused in real time, not when building ImaAdsLoader. #8565
Comments
Please could you give some more details about the bugs referred to in (b) so I can report this to the IMA SDK team to get the focusing behavior fixed? Separately, I think we can add |
When I use I would appreciate if #1 did not happen, as this messes with my app's focus (it's a TV app so stealing the focus when we don't want it has consequences in the app's UX). Ideally the WebView and its other children (e.g. time counter) wouldn't be focusable at all, just the skip button. And yes, to me it sounds like if you added |
Thanks. I will plan to submit that fix soon and it should be included in the next release. I also filed [Internal: b/179801842] to ask the IMA SDK to look into the unexpected focus stealing behavior. |
Issue: #8565 #minor-release PiperOrigin-RevId: 356691251
The additional method has been added. Can this issue be closed now? |
Issue: #8565 PiperOrigin-RevId: 356691251
We have a TV application that has a video player that can transition between fullscreen and collapsed mode. We're using the IMA extension and we want the Ads Skip Button to be focused only when the player is in fullscreen mode, not when it's collapsed. The ImaAdsLoader.Builder().setFocusSkipButtonWhenAvailable()' cannot be used, because:
a) We need to be able to decide whether the button gets focused or not at the time that the ad becomes skippable, not when the ImaAdsLoader is being constructed.
b) setFocusSkipButtonWhenAvailable is buggy and causes weird issues, like the ad container getting focused when the ad is loaded, instead of when the skip button becomes available.
On previous Exoplayer versions (2.11.8 and lower) we used to be able to use the following workaround:
In the current versions it is not possible to do that, because imaAdsLoader.adsLoader returns null.
Is there a recommended way of doing what I want, or do you think you could include such functionality into the SDK?
The text was updated successfully, but these errors were encountered: