-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dolby Vision/HDR10 selection based on connected TV device #8944
Comments
Could you please clarify what is the issue? I don't understand in which situation color are distorted. Especially why HDR10 support would impact Dolby Vision decoding and display.
Could you share what modification you have made to help us understand the issue. Is it a color space issue? |
Yes, it is a color space issue. We use a helper method which does the following....
and we use the Display capabilities to filter out the DASH or HLS renditions that have incompatible formats...i.e. in the case of the nVidia Shield connected to a HDR10 only TV, we would filter out any Dolby Vision representations/renditions, so that what's given to Exo is only HDR10. We use a custom DASH Parser/HLS Parser which can filter representations and also for extracting and supporting DASH and HLS based seek thumbnails (which is a different topic). What we noticed if allowing Exo to send a Dolby Vision representation to a HDR10 TV is the following color space issue. The above image is Exo on nVidia Shield connected to a Sony TV (2016 model, which only supported HDR10). Exo would deliver the Dolby Vision representation to this TV, resulting in color space distortions. By filtering the manifest based on the connected display's HDR capabilities, we are providing only HDR10 to Exo in this example. |
@AquilesCanta could this be a dup of [internal b/187012233]? |
@krocard I don't think so, but we can confirm. @ssenanayake Would you kindly provide sample media for each of the problematic usecases? If you don't want to share it publicly, you can send links to dev.exoplayer@gmail.com, with subject "Issue #8944". |
@AquilesCanta I have requested from out content team for the "Picard" episode with Dolby Vision and a DRM LA URL that I will email when I receive it. Thanks. |
I think it would be a better option if the content was not encrypted. I assume you have a clear version for all of your test streams, would you kindly provide a clear one? The reason is that DRM introduces yet another failure point, so it might mislead or delay the investigation. |
Hey @ssenanayake. We need more information to resolve this issue but there hasn't been an update in 14 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @ssenanayake if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
@ssenanayake We are looking at fixing this. Would you be able to provide a link to the DASH or HLS sample that you were using/mentioned above? If you're unable to share the test content publicly, please send it to dev.exoplayer@gmail.com with subject "Issue #8944" . Please also update this issue to indicate you've done this. |
Use case description
Currently Exoplayer selects the codec based on the available codecs on the device. But in the case of some devices like nVidia Shield, the device contains Dolby Vision AND HDR10 codecs.
We have noticed that Exo, in such cases can deliver Dolby Vision to a HDR10 TV or vice versa resulting in color distortions.
Proposed solution
Without modifying Exo, we at ViacomCBS have modified the player framework that uses Exo to take into consideration the connected TV's capabilities and deliver the appropriate rendition.
Alternatives considered
The text was updated successfully, but these errors were encountered: