Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unclickable" zones in track selectors of StyledPlayerView #9086

Closed
moneytoo opened this issue Jun 19, 2021 · 3 comments
Closed

"Unclickable" zones in track selectors of StyledPlayerView #9086

moneytoo opened this issue Jun 19, 2021 · 3 comments
Assignees
Labels

Comments

@moneytoo
Copy link
Contributor

Please see the screenshot of StyledPlayerView with opened audio track selector popup window (& layout bounds enabled). When there's at least one longer string (like "English, 5.1 surround sound" in this case), other shorter items do not span the full width and contain "unlickable" (meaning that click doesn't result in item selection) zone on the right.

Screenshot_20210619-215902

I'm not sure this is a bug per se, but it's definitely something IMHO doesn't feel right (based on my expectations after using Android UI). At least couple of times I tapped an item in a hope it would select but found that it didn't (until now I wasn't sure why it didn't work).

  • ExoPlayer version number: 2.14.1
  • Android version: Android 10
  • Android device: OnePlus 7
@ojw28
Copy link
Contributor

ojw28 commented Jun 21, 2021

I've also noticed this, and spent half a day or so trying to figure out how to fix it without success. We'd definitely welcome a pull request to fix the issue, if you manage to figure it out. Marking as a bug for now.

@ojw28
Copy link
Contributor

ojw28 commented Jun 21, 2021

Actually, I have a fix for this. I'll merge it shortly.

ojw28 added a commit that referenced this issue Jun 22, 2021
Issue: #9086
#minor-release
PiperOrigin-RevId: 380756562
@ojw28 ojw28 closed this as completed Jun 22, 2021
@moneytoo
Copy link
Contributor Author

Great! I tried the related changes and it works. Thank you!

icbaker pushed a commit that referenced this issue Jul 21, 2021
@google google locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants