-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrade to exoplayer 2.13.3, live playback speed became to variant speed. #9329
Labels
Comments
You can customise this behaviour as explained here: https://exoplayer.dev/live-streaming.html#configuring-live-playback-parameters |
@christosts @marcbaechinger - Could we reconsider the decision to enable variable playback speed for non-LL streams? I still don't think it's really expected, in general. |
icbaker
pushed a commit
that referenced
this issue
Jan 14, 2022
Live speed adjustment is used for all live playback at the moment, but has no user visible effect if the media is not played with low latency. To avoid unnecessary adjustment during playback without benefit, this change restricts the live speed adjustment to cases where either the user requested a speed value in the MediaItem or the media specifically defined a low-latency stream. Issue: #9329 PiperOrigin-RevId: 421514283
icbaker
pushed a commit
to androidx/media
that referenced
this issue
Jan 26, 2022
Live speed adjustment is used for all live playback at the moment, but has no user visible effect if the media is not played with low latency. To avoid unnecessary adjustment during playback without benefit, this change restricts the live speed adjustment to cases where either the user requested a speed value in the MediaItem or the media specifically defined a low-latency stream. Issue: google/ExoPlayer#9329 PiperOrigin-RevId: 421514283
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After upgrade to exoplayer 2.13.x onwards, the live playback speed became variant speed between range [0.97, 1.03], even for normal non-low latency live stream.
URI to test content for reproduction
https://livesim.dashif.org/livesim/mup_30/testpic_2s/Manifest.mpd"
ExoPlayer version number
Tested with 2.13.3
Android version
android 11
Android device
Samsung SM-P610
Since the 2.13.0, exoplayer introduce DefaultLivePlaybackSpeedControl.java, getAdjustedPlaybackSpeed function looks check
Because of DASH's DashMediaSource.java updateMediaItemLiveConfiguration logic
private void updateMediaItemLiveConfiguration(long nowInWindowUs, long windowDurationUs) {
Based on current implementation DashMediaSource targetOffsetMs's can not be TIME_UNSET any more, that means all live stream will play live stream with variant playback speed.
The text was updated successfully, but these errors were encountered: