-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant frame drop while playing 1920x1080 HLS video tracks on AFTSSS and AFTSS #9565
Comments
The bug report you linked to doesn't seem to contain enough information about the codec setup. I'm surprised 1080p AVC is reported to be not supported by the decoder, but ExoPlayer is not able to change that. Furthermore, I wouldn't be surprised that a software decoder performs poorly on a fire stick. |
If you look at the Please could you try reproducing again using v2.15.1, and capturing the |
Sorry about that, here is another bug report using the v2.15.1 demo app: Within it, I found one log with the
And here is one more run just capturing logcat output: |
Thanks for providing the detail. ExoPlayer queries As such, we cannot provide further help if the platform reports it does not support hardware decoding AVC. |
If the device claims to not support a profile/level that it does actually support, then we should probably consider adding a device specific workaround for that. Particularly given it's effectively a regression, presumably introduced when we started to check the profile/level. |
Is there a plan to address this in the future? We work on a similar app to Maxwell's and have been discussing upgrading the exoplayer but have not for fear of this issue. Should we attempt a work around or should we just wait for a fix? Thanks. I'd also like to push back on the designation of this as a 'device specific' bug. This is a regression from a previous build and from the description seems to be related into how it handles a codec that is failing. And just these two devices examples given have some of the largest share of the streaming TV in the country. |
I think my comment above about the profile/level check may have been misplaced. In any case, I've ordered one of these devices so that I can more easily see exactly what's going on. |
There are a few interesting things going on here that we should take a look at:
|
I think (1) is just that the codec string in the master playlist is incorrect (i.e., it's a problem with the media itself). (3) and (4) are the main things that we need to look at on the ExoPlayer side. In the meantime, I think you can get the old behavior with new releases of ExoPlayer with the workaround below, which should unblock you if you're stuck not being able to upgrade to a newer release:
|
This is a huge help/relief. Great explanation. Now with mediastreamvalidator and your comments I see what you mean by the miss matched levels. We will use this fix to get the same behavior. I do have one question though. The non 4K fire devices report they have two codecs ... OMX.MTK.VIDEO.DECODER.AVC and OMX.google.h264.decoder. The first is the better choice (hardware acceleration?). Does the ExoPlayer ask the second vocoder if it supports level 5? Or does it just use it because the first says it can't support the higher profile level. Because if doesn't ask the second time, it might be helpful to have it ask. And if they both don't support the higher level, it seems like the first codec would be the better choice. At least from what I see of the Fire devices. As an interesting side note. I've noticed that the Amazon port of the exoplayer has very few differences. But the main one is at that profile check (isCodecSupported) they have the method AmazonQuirks.skipProfileLevelCheck. If this is set to true it skips that test entirely and the player will select the first codec every time. I believe we would prefer your fix. But I thought I would mention this. Thanks again for looking into this. I feel like not only did we get a work around but also a an education! |
Correct.
In more detail, what happens is:
My current thinking for fixing this is:
|
Wow. Great details. Your fix sounds perfect for us at least. Those steps would fix our current issue very well. One more question though. I was impressed to see the adaptive algorithm (TrackSelection I think?) measure the bitrate and basically say 'we can handle more' and then to go to the higher resolution/bitrate/profile level. The player seems great about going up. But when the stuttering occurred I saw logging from the exoplayer that said it was dropping packets. But I never saw the adaptive algorithm go back down to a lower resolutions/bitrates. Was there a reason that it didn't step down to a lower resolution once it realized it was dropping packets? It looked to me like the code was setup to step down as well. I promise that's my last question. :) You folks have been awesome and playing with the exoplayer has given me a real appreciation for the great work you folks are doing. |
Adaptive bitrate is based on available network bandwidth. In this case there is sufficient network bandwidth, and it's CPU that's the limiting factor, so the logic to step down wont be triggered. We've discussed looking at additional metrics such as how frequently frames are being dropped (many frame drops is indicative of being CPU bound), and even things like the thermal state of the device, and factoring those into the adaptive bitrate logic as well. It's something we should look at at some point, and is particularly useful for devices that only ship with software decoders. In the case discussed here though, it's better just to avoid switching up to the 1080p stream in the first place :). |
This is a no-op change that updates supportsFormat to use the decoder list before it's reordered by format support. Instead, supportsFormat iterates through the decoders listed in their original priority order as specified by the MediaCodecSelector. The end result is identical. This is necessary groundwork for a subsequent change that will indicate in Capabilities whether the decoder that suppports the format is the primary one as specified by the MediaCodecSelector (i.e., the one at index=0 in the lists that are now used). Issue: google/ExoPlayer#9565 PiperOrigin-RevId: 414971986
Issue: google/ExoPlayer#9565 PiperOrigin-RevId: 415235358
This is a no-op change that updates supportsFormat to use the decoder list before it's reordered by format support. Instead, supportsFormat iterates through the decoders listed in their original priority order as specified by the MediaCodecSelector. The end result is identical. This is necessary groundwork for a subsequent change that will indicate in Capabilities whether the decoder that suppports the format is the primary one as specified by the MediaCodecSelector (i.e., the one at index=0 in the lists that are now used). Issue: #9565 PiperOrigin-RevId: 414971986
Issue: #9565 PiperOrigin-RevId: 415235358
*** Original commit *** Add capability flags for hardware and decoder support Issue: #9565 *** PiperOrigin-RevId: 416170329
Same problem here with LENOVO TB-X306X running the latest exoplayer version (2.16.1).
I'm not satisfied with my approach for devices running android 9 or below, because I need a training period to decide if the device can play smoothly or not. Waiting for a better solution or some advice. |
*** Original commit *** Add capability flags for hardware and decoder support Issue: google/ExoPlayer#9565 *** PiperOrigin-RevId: 416170329
*** Original commit *** Rollback of 3c4c1f4 *** Original commit *** Add capability flags for hardware and decoder support Issue: google/ExoPlayer#9565 *** *** PiperOrigin-RevId: 416285603
Adaptive video and audio selections will be limited to formats with the same level of DecoderSupport and HardwareAccelatationSupport, unless specifically allowed by new flags. If different levels of decoder support are available, prefer primary over fallback decoders and hardware-accelerated over software decoders (in this order). For video, also prefer more efficient codecs, if both are supported by hardware-accelerated primary decoders. Issue: #4835 Issue: #9565 PiperOrigin-RevId: 422345048
Adaptive video and audio selections will be limited to formats with the same level of DecoderSupport and HardwareAccelatationSupport, unless specifically allowed by new flags. If different levels of decoder support are available, prefer primary over fallback decoders and hardware-accelerated over software decoders (in this order). For video, also prefer more efficient codecs, if both are supported by hardware-accelerated primary decoders. Issue: google/ExoPlayer#4835 Issue: google/ExoPlayer#9565 PiperOrigin-RevId: 422345048
[REQUIRED] Issue description
Fire TV Stick - 3rd Gen (2020) (AFTSSS) and Fire TV Stick Lite - 1st Gen (2020) (AFTSS) consistently drop frames while playing 1920x1080 video tracks in HLS streams.
This bug report is a copy of a bug report I created on the Amazon ExoPlayer port repo: amzn/exoplayer-amazon-port#115
I haven't received any response on that repo, so I am re-posting this here.
Our production app uses the ExoPlayer Amazon port, but the issue occurs in both the ExoPlayer and the ExoPlayer Amazon port. This issue started when we upgraded our ExoPlayer Amazon port version from v2.10.6 to v2.11.3. So, I tested a few different ExoPlayer versions and confirmed the issue occurs on the following versions:
After some debugging, I have some insight as to why this started in v2.11:
In both v2.10 and v2.11, ExoPlayer's
MediaCodecVideoRenderer.getDecoderInfos()
method call returns a list of decoders available on the device. On v2.10, the order of the codecs was always returned in the following order, on both of these Fire Stick devices:[OMX.MTK.VIDEO.DECODER.AVC, OMX.google.h264.decoder]
So, to decode our HLS stream, the ExoPlayer would choose the first decoder in the list, OMX.MTK.VIDEO.DECODER.AVC (the hardware decoder). When the ExoPlayer checks the Format of our 1920x1080 video track in the HLS stream against this hardware codec, it returns that the hardware codec does not support the 1920x1080 video track. So, it would never attempt to play the 1920x1080 video track.
Starting in ExoPlayer v2.11, the ExoPlayer's
MediaCodecVideoRenderer.getDecoderInfos()
implementation changed. This method started sorting the list of decoders by 'Format' support.The sorting recognizes that the hardware decoder (OMX.MTK.VIDEO.DECODER.AVC) does not support the 1920x1080 video track in our HLS stream, but the software decoder (OMX.google.h264.decoder) does, so the sorting method call sorts the list of available decoders into the following order: [OMX.google.h264.decoder, OMX.MTK.VIDEO.DECODER.AVC]. The ExoPlayer then chooses the first decoder in the list, the software decoder, to decode the 1920x1080 video track. However, during playback, there is nearly constant frame drop causing a bad experience for the user.
I don't know what's causing the software codec to perform so poorly, but there are logs indicating frames being dropped:
I also don't know why these two Fire Sticks are reporting that their hardware codec does not support the 1920x1080 video track. Seemingly, the same OMX.MTK.VIDEO.DECODER.AVC hardware codec can play 1920x1080 video tracks on the Fire TV Stick - 2nd Gen (2016-2019) (AFTT), but not on the newer models.
Finally, this may be related to amzn/exoplayer-amazon-port#42 but I'm not sure.
[REQUIRED] Reproduction steps
This does not reproduce with the Apple HLS samples in the demo app. However, you can reproduce it in the demo app using this sample I found on Bitmovin's website: https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8
Notice the choppiness of the video and the logs being printed. If the issue does not reproduce the first time, try:
[REQUIRED] Link to test content
https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8
I can provide our production HLS streams if more than this sample is needed.
[REQUIRED] A full bug report captured from the device
Fire TV Stick Lite - 1st Gen (2020) (AFTSS):
bugreport-sheldon-PS7234-2021-05-05-16-39-26.zip
[REQUIRED] Version of ExoPlayer being used
It seems to reproduce in all ExoPlayer versions (Amazon port or not) starting with v2.11.
[REQUIRED] Device(s) and version(s) of Android being used
https://developer.amazon.com/docs/fire-tv/fire-os-overview.html
The text was updated successfully, but these errors were encountered: