-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forced subtitle DASH support checking for wrong Role@value #9727
Comments
Thanks for pointing this out - as you've probably realised, we added support for this after it was requested in #8781 and we used Given you've mentioned later in that thread that Shaka have have also done the same thing, I suspect there will now be content out there with a mix of the two spellings :( It's probably best for now if I update ExoPlayer to support both spellings - so that content that used to work with ExoPlayer (with the 'wrong' spelling) will keep working. I'll make that change. |
Yes, makes sense as a pragmatic approach. Thanks for quick reply! |
Issue: #9727 #minor-release PiperOrigin-RevId: 412266397
Issue: google/ExoPlayer#9727 #minor-release PiperOrigin-RevId: 412266397
When checking for forced subtitle behaviour in the
DashManifestParser.java
, theRole@value
being matched against isforced_subtitle
:https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1477
https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1547
But according to the 4th edition of ISO/IEC 23009-1 (publicly available here) this should be checking for
forced-subtitle
. This is defined in Table 31 —Role@value
attribute for scheme with a value"urn:mpeg:dash:role:2011"
:Role@value
forced-subtitle
text
The text was updated successfully, but these errors were encountered: