Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getMetrics usage for MediaCodecAdapter #9766

Closed
harini113 opened this issue Dec 8, 2021 · 4 comments
Closed

getMetrics usage for MediaCodecAdapter #9766

harini113 opened this issue Dec 8, 2021 · 4 comments
Assignees
@christosts
Labels
question

Comments

@harini113
Copy link

is the api getMetrics() supported with the new MediaCodecAdapter in exoplayer library 2.15.1 or newer

I have been using the getMetrics() api to retrieve information like Encoder/Decoder/Ht/Width and other information for the codec created. But in the new library, we migrated to using MediaCodecAdapter instead of MediaCodec. I do not see the getMetrics api supported for this? Is this something that will be added in future versions or is there a different approach for usage of this api.
@harini113
Copy link
Author

hi christosts, Any update on the usage?

@christosts
Copy link
Contributor

We will add getMetric() on MediaCodecAdapter - I will post an update once the commit is submitted.

christosts added a commit that referenced this issue Dec 15, 2021
@christosts
Add getMetrics() in MediaCodecAdapter
b5206b8 
Before the introduction of the MediaCodecAdapter, users could get
access directly to the MediaCodec instance from
MediaCodecRenderer.getCodec() and then retrieve the codec metrics.

This change exposes MediaCodec.getMetrics() on the MediaCodecAdapter.

Issue: #9766

#minor-release

PiperOrigin-RevId: 416343023
@christosts
Copy link
Contributor

Please see the commit linked above - the API will be available on the next release

@harini113
Copy link
Author

thank you

tonihei pushed a commit to androidx/media that referenced this issue Jan 5, 2022
@christosts @tonihei
Add getMetrics() in MediaCodecAdapter
531ff0e 
Before the introduction of the MediaCodecAdapter, users could get
access directly to the MediaCodec instance from
MediaCodecRenderer.getCodec() and then retrieve the codec metrics.

This change exposes MediaCodec.getMetrics() on the MediaCodecAdapter.

Issue: google/ExoPlayer#9766

#minor-release

PiperOrigin-RevId: 416343023
@google google locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christosts christosts

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harini113 @christosts