Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ID3 metadata for mp3 + mp4 #979

Closed
Sicness opened this issue Nov 23, 2015 · 6 comments
Closed

Expose ID3 metadata for mp3 + mp4 #979

Sicness opened this issue Nov 23, 2015 · 6 comments

Comments

@Sicness
Copy link

Sicness commented Nov 23, 2015

Is it possible to get metadata (like artist, song name and etc) from HTTP mp3 stream (radio) via some of ExoPlayer classes? Does the player has such functionality? If no, do you have recommendation how to get the metadata?

@ojw28
Copy link
Contributor

ojw28 commented May 22, 2016

We could probably support this relatively easily, given we already have ID3 parsing for MPEG-TS.

@ojw28 ojw28 changed the title Get metadata from HTTP stream Expose ID3 metadata for mp3 + mp4 Oct 12, 2016
@ojw28
Copy link
Contributor

ojw28 commented Oct 12, 2016

@cbfiddle - For mp4 do you think it's fine to propagate the metadata in the audio track only? I've made this change on dev-v2-id3, but wonder whether you can think of any edge cases? We could add it to the video track for the specific case where no audio track is present to handle that edge case, but in practice it seems unlikely we'd encounter this case.

@cbfiddle
Copy link
Contributor

I have no opinion. My use case is audio only.

On Oct 12, 2016, at 9:37 AM, ojw28 notifications@github.com wrote:

@cbfiddle https://github.com/cbfiddle - For mp4 do you think it's fine to propagate the metadata in the audio track only? I've made this change on dev-v2-id3, but wonder whether you can think of any edge cases? We could add it to the video track for the specific case where no audio track is present to handle that edge case, but in practice it seems unlikely we'd encounter this case.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #979 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AGUkmfhoGfXPDpJ-LAva3cyEgS1tu91cks5qzQzSgaJpZM4Gno8r.

@ojw28
Copy link
Contributor

ojw28 commented Oct 27, 2016

ID3 support for MP3 and MP4 has been merged in #2008.

@ojw28 ojw28 closed this as completed Oct 27, 2016
@cbfiddle
Copy link
Contributor

cbfiddle commented May 22, 2017 via email

@ojw28
Copy link
Contributor

ojw28 commented May 22, 2017

I don't think it would be possible to implement this properly by receiving the ID3 data and then setting something back on the player. You'd really need this to happen synchronously within the player itself. If there are standard tags for this then please file a new issue to track implementing this, together with details about the standard tags and sample media we can test with.

@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants