-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Thumbnails in DASH #10793
Added support for Thumbnails in DASH #10793
Conversation
…for a video position and with that allowing to display thumbnail images while seeking through a video. The demo app has beed enhanced to use this new API and display thumbnail images above the seek bar while scrubbing.
Thanks for sharing the code in a PR! I think the general direction doesn't yet fully align with the discussion in #3752 because it looks like your proposal is moving the entire loading and caching out of the player to let the app handle this separately. This is not ideal because it means the app has to replicate many parts of the logic that lives inside the player already (how to load data, how to cache it, find the appropriate next sample after a seek, handling adaptive switches between resolutions etc). As a first step, this may still be appropriate just to make sure an app can do this if wants to. The app can access the |
…leCountVertical' to class Format. DashManifestParser adjusted to parse these values from an EssentialProperty tag of an Image AdaptationSet. With this change, DashManifest does not have to do any parsing inside the new getThumbnailDescriptions() method. Moreover, both classes ThumbnailDescription and ThumbnailProvider adjusted to use these two properties / naming scheme accordingly.
Hi @tonihei, thank you for your very quick response. As my colleague @suraneau mentioned in the discussion in #3752 , we were aiming to implement the approach similar to dash.js by offering a thumbnail API to easily fetch thumbnail information for App developers - as requested by companies in the discussion and as typically needed for DASH playback. I looked into your suggestion for adding two new properties, I fully agree and adjusted We're again looking forward to your feedback. Best regards, |
…imilar to Text AdaptationSets, see issue 4029 (google#4029).
Thanks for the updates! Could you just keep the changes to |
# Conflicts: # library/common/src/main/java/com/google/android/exoplayer2/Format.java
Hi @tonihei, Best regards, |
Thanks for the update! I'll merge the changes internally, but without the ThumbnailDescription part (which can be done in app code if needed). |
PiperOrigin-RevId: 506261584 (cherry picked from commit 107e0c6)
PiperOrigin-RevId: 506261584 (cherry picked from commit c6569a3)
This PR enhances the DashManifest class to allow fetching Thumbnail Meta Data for a video position and with that allowing to display thumbnail images while seeking through a video, as discussed in issue #3752 by my colleague @suraneau.
This approach is similar to how dash.js handles thumbnails. Only the metadata (like the URL) for the thumbnail is provided by ExoPlayer via a new API. The tasks of loading, caching, crop/zoom and rendering of the (tile) images will be done by the external app/UI logic.
The demo app has been enhanced as well to use this new API and display thumbnail images above the seek bar. A few streams have been added for testing.
We're looking forward to your feedback.
Thank you!
Best regards,
Görkem