Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label attribute support for DASH audio/text #2904

Closed
wants to merge 1 commit into from

Conversation

itaykinnrot
Copy link
Contributor

When playing a stream with multiple audio tracks, currently the only way to identify the different tracks is using the lang attribute of AdaptationSet. We have customers who would like to customize the label that is displayed to the end user for selecting the audio track. Also, multiple audio tracks are sometimes used for uses cases which are not multiple languages, for example - one audio track with background music and one without it.
While it is possible to pass this info out-of-band, we feel it makes most sense to pass it in-band in the MPD. Other protocols have support for this - in HLS you can set the NAME attribute of EXT-X-MEDIA, and in MSS there's a Name attribute on StreamIndex

When playing a stream with multiple audio tracks, currently the only way to identify the different tracks is using the lang attribute of AdaptationSet. We have customers who would like to customize the label that is displayed to the end user for selecting the audio track. Also, multiple audio tracks are sometimes used for uses cases which are not multiple languages, for example - one audio track with background music and one without it.
While it is possible to pass this info out-of-band, we feel it makes most sense to pass it in-band in the MPD. Other protocols have support for this - in HLS you can set the NAME attribute of EXT-X-MEDIA, and in MSS there's a Name attribute on StreamIndex
@ojw28
Copy link
Contributor

ojw28 commented Jun 6, 2017

Is there a way to do this within the DASH spec (or DASH IF recommendations)? It doesn't look like @label is actually defined anywhere in either.

@itaykinnrot
Copy link
Contributor Author

I'll try...
But i still think this is useful and some packagers already support it.
Shaka project also accept it.
Thanks,

@OrenMe
Copy link

OrenMe commented Jul 11, 2017

Hi, I think this is a valid use case without changing the spec.
MPD is just an XML scheme so adding an attribute or even a node wouldn't break any parser AFAIK.
And I think this is quite useful and is supported on HLS and as stated, some packagers do support this feature.

@ojw28
Copy link
Contributor

ojw28 commented Jul 11, 2017

My main concern is that it will be standardized using some other attribute name or mechanism, that we'll have to change it, and that we'll end up annoying a bunch of people who have come to rely on it. So I'd feel much happier if the approach were documented somewhere. You could file a request asking guidance to be added to the DASH-IF guidelines here or here, for example.

@ojw28
Copy link
Contributor

ojw28 commented Jun 6, 2018

Sorry for ignoring this for so long. Looking at this again, I'd be happy to merge it. However the pull request needs to go to dev-v2 rather than release-v2. If you update the change to build against latest dev-v2 and open a new pull request into that branch, then we'll get it merged in. Thanks!

Closing this one, since a new one will need opening into the correct branch.

@ojw28 ojw28 closed this Jun 6, 2018
@itaykinnrot
Copy link
Contributor Author

#4391

@ojw28 ojw28 self-requested a review June 19, 2018 10:04
@ojw28 ojw28 removed their request for review June 19, 2018 10:05
@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants