Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2975 - fix for flac extension build #2977

Closed
wants to merge 1 commit into from
Closed

issue #2975 - fix for flac extension build #2977

wants to merge 1 commit into from

Conversation

oikmar
Copy link

@oikmar oikmar commented Jun 21, 2017

failing with "use of undeclared identifier - memset"

  • include strings.h for memeset.
  • tested with flac-1.3.1

…lared identifier - memset"

- include strings.h for memeset.
- tested with flac-1.3.1
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@oikmar
Copy link
Author

oikmar commented Jun 21, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@erdemguven erdemguven self-assigned this Jun 21, 2017
@erdemguven erdemguven self-requested a review June 21, 2017 12:16
@ojw28
Copy link
Contributor

ojw28 commented Jun 26, 2017

The change needs to go into the dev-v2 branch, so we'll close this pull request and submit a change directly to that branch today. Thanks for bringing this issue to our attention!

@ojw28 ojw28 closed this Jun 26, 2017
ojw28 pushed a commit that referenced this pull request Jun 26, 2017
In the latest NDK version (r15) compilation fails because 'memset' isn't defined. Included cstring header.

Issue: #2977

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=160139022
ojw28 pushed a commit that referenced this pull request Jun 30, 2017
In the latest NDK version (r15) compilation fails because 'memset' isn't defined. Included cstring header.

Issue: #2977

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=160139022
@google google locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants