Update ContentDataSource.java

[axet]

Checking File size makes more sense then asking for InputStream cached bytes.

#3426 explanation

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[ojw28]

This comment doesn't seem to make sense given then change being made? Does the if block itself still make sense?

[axet]

bytesRemaining = inputStream.available()

• for the momen when you open Pipe this call can return 0.

bytesRemaining = ((FileInputStream) inputStream).getChannel().size();

• FileDescription for correct file in file system, this call will return correct file size.

Again. I do not understand, why you asking this. Propbably need more testing.

[ojw28]

In the previous code we actually called inputStream.available() and then did something conditionally on the value being 0. We're not making an inputStream.available() call any more, so the comment doesn't make sense. Can size() return 0? If not why is this if block still here? If so the comment needs changing.

[ojw28]

I think it's possible for multiple assets to be in a single file. In which case is size() the size of just this one, or of all of them? I think you might want to subtract position() of the FileChannel to get correct behavior?

[axet]

Not sure what do you mean, FileChannel one per file.

[ojw28]

I don't think the uri for which the source is being opened necessarily corresponds to the whole file though. Else this code wouldn't need to be using assetFileDescriptor.getStartOffset as above? If the uri only corresponds to a part of the file, that needs to be accounted for.

[ojw28]

Even if the uri does correspond to the whole file, you'd need to subtract skipped if it's non-zero.

[axet]

Then correct line is:

bytesRemaining = ((FileInputStream) inputStream).getChannel().size() - assetFileDescriptor.getStartOffset

[ojw28]

• We wont be able to merge this without a signed CLA.
• Pull requests need to go to the dev-v2 branch, not release-v2. Please address the comments and make a new request to that branch.

[axet]

1. Will wont be able to merge this without a signed CLA.

less then 5 lines of code need to sign anything? Eclipse treat small bug fixes wihtout any paper work. I do not wana bother to sing anything.

2. Ok, I close this one, but keep reffered issue open.

[ojw28]

Please do not send a second pull request if you don't intend to sign the CLA. We wont be able to accept it. Thanks.

[axet]

@ojw28 I didnt know you trying to use "documents" to protect you from the world. I would'nt pull again.

Anyway you can't protect yourself using this technique sign - and enter. I can prove I made this code having it before the code come to the repository, and since it get there without my sign it be equals staling code. So, sign or no sign - always possible to make you/google guilty and violating copyright slavery... Just make it simple, opensource and fun. BTW i'm not going to sue anyway. Just show you how stupid "CLA" is.