Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause/resume a single download #4860 #5165

Closed
wants to merge 10 commits into from

Conversation

AleksanderMielczarek
Copy link

@AleksanderMielczarek AleksanderMielczarek commented Nov 28, 2018

This PR adds possibility to pause/resume single download (#4860). Please take a look and decide whether this is correct approach, if so I'll add tests.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@AleksanderMielczarek AleksanderMielczarek changed the title Pause / stop a single download #4860 Pause/resume a single download #4860 Nov 28, 2018
@AleksanderMielczarek
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@AleksanderMielczarek
Copy link
Author

Implementation seems to be working ok. Added some tests.

@erdemguven
Copy link
Contributor

Thanks for the pull request. Actually we're doing some major changes on DownloadManager which breaks this change. The good news is we're planning the add this feature as well. I'll check if we can a least partially use this code.

@volkansahin45
Copy link

Will it be ready at next release? @erdemguven

@meenukrishnamurthy
Copy link

Is this feature merged in the current release??

@erdemguven
Copy link
Contributor

We're working on a similar change currently. There is no certain date or release it will be available but I can say sometime soon.

@erdemguven erdemguven closed this Jan 2, 2019
@erdemguven erdemguven reopened this Jan 2, 2019
@AleksanderMielczarek
Copy link
Author

@erdemguven Do you have any updates?

@ojw28
Copy link
Contributor

ojw28 commented May 5, 2019

The ability to stop and resume an individual download is supported in 2.10.0 with DownloadManager.setStopReason. In the normal case of using a DownloadService, you should use DownloadService.sendSetStopReason or DownloadService.buildSetStopReasonIntent. The 2.10.0 release should happen next week (and we've already made a 2.10.0-alpha2 available that contains this functionality.

@ojw28 ojw28 closed this May 5, 2019
@google google locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants