-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for UDP data source #6036
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Could you please ensure the CLA is signed for the account you used for the commits? Otherwise we can't look at this pull request. |
Hi @tonihei . It looks like I had an alternative email associated to my main email account. I already deleted that alternative account and I have the same email address for the commit and in the agreement. So let me know if the problem is already solved. I previously created another pull request that I had to close because a problem with emails between my github account and my PC credentials. In this new pull request, It looks like the bot detected the previous signed CLA and I didn't receive any CLA request to sign. If It's useful, when I did this pull request, the status was "Merged" but it changed to Open and I don't know why. Many thanks, Angel. |
You should be able to sign the CLA at https://cla.developers.google.com/. The missing one is for the @arodriguez (email: |
@tonihei I already signed the CLA at that page with the @arodriguez email that you mentioned. Please, tell me if It's solved now. Many thanks |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Yes, it's working now. Thanks! |
Change looks good and should be able to merge. You mentioned that "I saw some people asking for this feature in ExoPlayer's issues. ". Can you point me to these issues so that we can mention it's solved in there? |
Hi @tonihei I will send you the answer on Monday. I already started my weekend |
Thanks! |
In the current release, there is no support to reproduce videos throughout UDP. As a result, I wanted to modify just this single class to add the functionality. I have tested it with an UDP video and it worked like a charm. Just a few changes were needed.
In order to test and make sure that these changes can be applied to next release, it's only necessary to put an UDP video in the demo and ensure that it works correctly.
I saw some people asking for this feature in ExoPlayer's issues. So I think it would be very useful to add this functionality in future releases. It would keep us aside of having to instantiate your whole project locally in our repositories.