Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UDP data source #6036

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Support for UDP data source #6036

merged 1 commit into from
Jun 14, 2019

Conversation

angelrc96
Copy link

In the current release, there is no support to reproduce videos throughout UDP. As a result, I wanted to modify just this single class to add the functionality. I have tested it with an UDP video and it worked like a charm. Just a few changes were needed.

In order to test and make sure that these changes can be applied to next release, it's only necessary to put an UDP video in the demo and ensure that it works correctly.

I saw some people asking for this feature in ExoPlayer's issues. So I think it would be very useful to add this functionality in future releases. It would keep us aside of having to instantiate your whole project locally in our repositories.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@tonihei
Copy link
Collaborator

tonihei commented Jun 14, 2019

Could you please ensure the CLA is signed for the account you used for the commits? Otherwise we can't look at this pull request.

@angelrc96
Copy link
Author

angelrc96 commented Jun 14, 2019

Could you please ensure the CLA is signed for the account you used for the commits? Otherwise we can't look at this pull request.

Hi @tonihei . It looks like I had an alternative email associated to my main email account. I already deleted that alternative account and I have the same email address for the commit and in the agreement. So let me know if the problem is already solved. I previously created another pull request that I had to close because a problem with emails between my github account and my PC credentials. In this new pull request, It looks like the bot detected the previous signed CLA and I didn't receive any CLA request to sign. If It's useful, when I did this pull request, the status was "Merged" but it changed to Open and I don't know why. Many thanks, Angel.

@tonihei
Copy link
Collaborator

tonihei commented Jun 14, 2019

You should be able to sign the CLA at https://cla.developers.google.com/. The missing one is for the @arodriguez (email: ***@ar****a.com)

@angelrc96
Copy link
Author

You should be able to sign the CLA at https://cla.developers.google.com/. The missing one is for the @arodriguez (email: @ar*a.com)

@tonihei I already signed the CLA at that page with the @arodriguez email that you mentioned. Please, tell me if It's solved now. Many thanks

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tonihei
Copy link
Collaborator

tonihei commented Jun 14, 2019

Yes, it's working now. Thanks!

@tonihei tonihei self-assigned this Jun 14, 2019
@tonihei
Copy link
Collaborator

tonihei commented Jun 14, 2019

Change looks good and should be able to merge. You mentioned that "I saw some people asking for this feature in ExoPlayer's issues. ". Can you point me to these issues so that we can mention it's solved in there?

@tonihei tonihei merged commit 28ee05f into google:dev-v2 Jun 14, 2019
tonihei added a commit that referenced this pull request Jun 14, 2019
PiperOrigin-RevId: 253228214
@angelrc96
Copy link
Author

Hi @tonihei I will send you the answer on Monday. I already started my weekend

@angelrc96
Copy link
Author

Change looks good and should be able to merge. You mentioned that "I saw some people asking for this feature in ExoPlayer's issues. ". Can you point me to these issues so that we can mention it's solved in there?

Hi @tonihei, here you have the links you asked to me:
#2630
#2029

@tonihei
Copy link
Collaborator

tonihei commented Jun 17, 2019

Thanks!

ojw28 pushed a commit that referenced this pull request Jun 19, 2019
PiperOrigin-RevId: 253228214
@google google locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants