Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 426 - send messages to dead thread. #624

Closed
wants to merge 7 commits into from
Closed

Fix issue 426 - send messages to dead thread. #624

wants to merge 7 commits into from

Conversation

MaTriXy
Copy link

@MaTriXy MaTriXy commented Jul 15, 2015

issue #426

@ojw28
Copy link
Contributor

ojw28 commented Jul 15, 2015

Please style this code in the same way as the rest of the code base. It's very difficult to review it when virtually every line has changed due to application of a different code style.

@MaTriXy
Copy link
Author

MaTriXy commented Jul 15, 2015

Sorry - i thought apply the code formatting fixed it..
Doing a revert now.

@ojw28
Copy link
Contributor

ojw28 commented Jul 21, 2015

Hm. This doesn't prevent the message in all cases, although probably catches most occurrences. I'll have a think.

@MaTriXy
Copy link
Author

MaTriXy commented Jul 23, 2015

Hi,
I can't kill the handler from where we are but i can avoid sending messages when the tread is dead.
This way messages are not sent when not needed.

@thomaspaulmann
Copy link

What about this pull request? I have also issues with sending messages to a dead thread.
It happens when you're starting multiple streams in a short period of time. For example selecting the same video multiple times in a listview.
For clearance: Every click releases the current exo player instance and creates a new one with the specific streaming url.

@ojw28
Copy link
Contributor

ojw28 commented Sep 14, 2015

The only issue this causes is a warning in the logs. There are no user facing issues related to this warning. For now, I think we're ok doing nothing until we have time to think about a complete fix.

@ojw28
Copy link
Contributor

ojw28 commented Jun 19, 2016

This is fixed in a more correct way in the 2.x.x experimental branch. We're not planning to take a fix for 1.x, since the issue is largely benign.

@ojw28 ojw28 closed this Jun 19, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants