-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 426 - send messages to dead thread. #624
Conversation
Please style this code in the same way as the rest of the code base. It's very difficult to review it when virtually every line has changed due to application of a different code style. |
Sorry - i thought apply the code formatting fixed it.. |
revert code formatting.
Hm. This doesn't prevent the message in all cases, although probably catches most occurrences. I'll have a think. |
Hi, |
update repo
What about this pull request? I have also issues with sending messages to a dead thread. |
The only issue this causes is a warning in the logs. There are no user facing issues related to this warning. For now, I think we're ok doing nothing until we have time to think about a complete fix. |
update repo
This is fixed in a more correct way in the 2.x.x experimental branch. We're not planning to take a fix for 1.x, since the issue is largely benign. |
issue #426