dev: adding sorting for TrackSelectionDialog and TrackSelectionDialog… #7798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojw28
reviewed
Aug 26, 2020
There was a problem hiding this comment.
I put some comments inline. For the demo app changes, I think we probably don't want to take those, since it makes the demo app quite a bit more complicated. Feel free to leave them in for now if they're useful for your own testing, but let's remove them when we merge.
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionDialogBuilder.java
Outdated
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionDialogBuilder.java
Outdated
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionView.java
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionView.java
Outdated
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionView.java
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionView.java
Outdated
Show resolved
Hide resolved
library/ui/src/main/java/com/google/android/exoplayer2/ui/TrackSelectionView.java
Outdated
Show resolved
Hide resolved
|
Everything should be okay now, I'm only concern if for some reason a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement match with this issue #7709
This is my first time contributing to a project, feel free to tell me if I did something wrong.
Developers need to add their
comparatorwhich is type ofComparator<Format>and it'll sort it the way they implement itPS: I got an issue with my repo and had to delete it, that's why there is 2 merge request, feel free to close/delete this one: #7715