Adjust initial selection of HlsChunckSource.InitializationTrackSelection #8025
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes done in 0670782, there exists the possibility that
indexOf(group.getFormat(0))
returns-1
(i.e. the track is not part of the selection).This will earlier or later result in an
ArrayIndexOutOfBoundsException
.*After having a look at the
BaseTrackSelection
I assumed that theselectedIndex
may not be-1
or in general any invalid index for the selection.To always have a valid selection we just select the first one. (Which is basically equivalent to the previous behaviour if the above mentioned change was not implemented.)
* I observed the exception in the
updateSelectedTrack -> isBlacklisted
call