This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Update "Preventing mixed content" section and prepare for publishing #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing bundler install step - Updated sass version, see sass/node-sass#653
- Add screenshots - Minor style updates
Remove published: false
-fix scheme capitalization -remove unneeded ’//‘
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -1,15 +1,14 @@ | |||
| --- | |||
| layout: article | |||
| published: false | |||
There was a problem hiding this comment.
Does this work like I think it does? Would removing this here but leaving published:false in the index.markdown make it visible in prod but unlisted?
|
I signed it! Covered by Google CLA |
johyphenel
added a commit
to johyphenel/WebFundamentals
that referenced
this pull request
Sep 27, 2015
johyphenel
added a commit
to johyphenel/WebFundamentals
that referenced
this pull request
Sep 27, 2015
Updated branch to changes from master google#1875
|
@petele let me know if there is anything I missed with this update :) |
|
CLAs look good, thanks! |
petele
added a commit
that referenced
this pull request
Sep 28, 2015
Update "Preventing mixed content" section and prepare for publishing
gauntface
pushed a commit
that referenced
this pull request
Sep 28, 2015
…nto material-branch * 'material-branch' of github.com:google/WebFundamentals: First bit of promises migration changes media to images, video and audio manual merge of #1875
|
|
||
| <!-- Span required to prevent rest of page from being indented. | ||
| https://github.com/google/WebFundamentals/issues/1873 --> | ||
| <span></span> |
gauntface
pushed a commit
that referenced
this pull request
Oct 29, 2015
…nto material-branch * 'material-branch' of github.com:google/WebFundamentals: First bit of promises migration changes media to images, video and audio manual merge of #1875
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc
Mixed content