[lightouse] update template & add "font sizes" reference #5810
Conversation
|
👍 |
|
|
||
| [viewport]: /web/tools/lighthouse/audits/has-viewport-meta-tag | ||
|
|
||
| ### Characters per line {: #characters } |
There was a problem hiding this comment.
This guidance isn't directly relevant to the audit so it's ok to drop it. The current "Learn more" link only points here because the PSI docs on font sizes disappeared and redirected here.
There was a problem hiding this comment.
Yeah, I get what you're saying. What I was thinking is that it's nice to use this reference as an entry point to related topics that the developer might be interested in, but the tradeoff is that it clutters up the reference with less-relevant content. Something to consider in general.
cc @paulirish & @vinamratasingal
There was a problem hiding this comment.
yeah line length is technically a readability concern and separate from the legibility of small glyphs. 😛
but i think we should let prescriptive docs speak for themselves. and just link em without further elaboration.
| @@ -48,6 +48,8 @@ toc: | |||
| path: /web/tools/lighthouse/audits/aspect-ratio | |||
| - title: Document Does Not Have A Meta Description | |||
| path: /web/tools/lighthouse/audits/description | |||
| - title: Document Doesn't Use Legible Font Sizes | |||
There was a problem hiding this comment.
Should we update the audit config to use "Does Not" for consistency with other audits?
There was a problem hiding this comment.
One way or the other, I was thinking about putting a PR in to make it consistent across reports
There was a problem hiding this comment.
Contracting it makes it feel a little more informal, which seems more in line with LH's voice
|
👍 |
|
🎉 This has been pushed live to https://developers.google.com/web/ |
Hey @rviscomi and @kdzwinel, have a look at the reference for the "font size" audit, plz!
What's changed, or what was fixed?
Fixes: N/A
Target Live Date: 2018-02-28
gulp testlocally and all tests pass.type-somethinglabel.CC: @petele