Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing ssbo buffers to the same value increases their size #575

Closed
sarahM0 opened this issue Jul 15, 2019 · 2 comments · Fixed by #585
Closed

Resizing ssbo buffers to the same value increases their size #575

sarahM0 opened this issue Jul 15, 2019 · 2 comments · Fixed by #585
Assignees
Labels
bug Something isn't working

Comments

@sarahM0
Copy link
Contributor

sarahM0 commented Jul 15, 2019

This issue came out of MR #564 - for more info read the comments on it.
This issue is causing three tests to fail in dawn backend (theses have multiple ssbo calls for the same buffer as a result that buffer's size gets multiplied till it gets so big it overflows and dawn backed asserts for creating a buffer of size 0):
./cases/draw_array_after_draw_rect.vkscript
./cases/draw_rect_after_draw_array.vkscript
./cases/draw_rect_and_draw_array_mixed.vkscript

@dj2
Copy link
Collaborator

dj2 commented Jul 31, 2019

Is this fixed, or just effected by the compute cl? @sarahM0

@dj2 dj2 reopened this Jul 31, 2019
@sarahM0
Copy link
Contributor Author

sarahM0 commented Jul 31, 2019

Well since we took another approach - using a separate member variable in buffer.cc to save the max size instead of changing the actual size while processing ssbo/ubo - this is not an issue anymore.

@sarahM0 sarahM0 closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants