Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all warnings in engine_vulkan_debugger #886

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Fix all warnings in engine_vulkan_debugger #886

merged 2 commits into from
Jul 16, 2020

Commits on Jul 16, 2020

  1. Fix all warnings in engine_vulkan_debugger 

    Remove unused functions.
Add explicit casts.
Avoid variable shadowing.
Be explicit with virtual `override`s
Use epsilons for float compares.
Move VkDebugger to anonymous namespace, as it isn't referenced outside
the `engine_vulkan_debugger` compilation unit.
Remove pointless semi-colons.
    @ben-clayton
    ben-clayton committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e5215c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-pedantic-warnings

    @dj2
    dj2 authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    65499f1 View commit details
    Browse the repository at this point in the history