Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe ToT docker image version as head commit short sha #705

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Describe ToT docker image version as head commit short sha #705

merged 1 commit into from
Sep 11, 2024

Conversation

0405ysj
Copy link
Collaborator

@0405ysj 0405ysj commented Sep 2, 2024

No description provided.

0405ysj
0405ysj commented Sep 2, 2024
View reviewed changes
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
@0405ysj 0405ysj force-pushed the docker_workflow branch 2 times, most recently from 04f2ac8 to 016180b Compare September 2, 2024 05:05
@0405ysj 0405ysj marked this pull request as ready for review September 2, 2024 05:17
@0405ysj 0405ysj marked this pull request as draft September 2, 2024 05:19
@0405ysj 0405ysj force-pushed the docker_workflow branch 13 times, most recently from 60f0ecc to acdd63e Compare September 2, 2024 06:23
@0405ysj 0405ysj marked this pull request as ready for review September 2, 2024 06:23
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Sep 2, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Sep 2, 2024
@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 4, 2024

@ser-io PTAL

ser-io
ser-io requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@ser-io ser-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these jobs to the Artifacts workflow https://github.com/google/android-cuttlefish/blob/main/.github/workflows/artifacts.yaml, this way our users can find all our artifacts in the same workflow page.

@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 5, 2024

Let's move these jobs to the Artifacts workflow https://github.com/google/android-cuttlefish/blob/main/.github/workflows/artifacts.yaml, this way our users can find all our artifacts in the same workflow page.

I'm not still certain with strategies for managing workflows. Though I move docker images into artifacts.yaml, we cannot say all our artifacts are in there. For instance, host-image-ci.yml uploads lots of host image artifacts to there.

How do you want to manage Github workflow, in overall?

@ser-io
Copy link
Member

ser-io commented Sep 5, 2024

Let's move these jobs to the Artifacts workflow https://github.com/google/android-cuttlefish/blob/main/.github/workflows/artifacts.yaml, this way our users can find all our artifacts in the same workflow page.

I'm not still certain with strategies for managing workflows. Though I move docker images into artifacts.yaml, we cannot say all our artifacts are in there. For instance, host-image-ci.yml uploads lots of host image artifacts to there.

How do you want to manage Github workflow, in overall?

Yes, I missed host-image-ci.yml exporting artifacts and didn't act proactively there. I'll work with @WeiChungHsu to have them moved to a single Github workflow, so we can find all of our ToT artifacts on a single page.

@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 10, 2024

Yes, I missed host-image-ci.yml exporting artifacts and didn't act proactively there. I'll work with @WeiChungHsu to have them moved to a single Github workflow, so we can find all of our ToT artifacts on a single page.

Ack. I updated Github workflow, to build artifacts in .github/workflows/artifacts.yaml.

@0405ysj 0405ysj requested a review from ser-io September 10, 2024 03:26
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Sep 10, 2024
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Sep 10, 2024
@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 11, 2024

@adelva1984 @rmuthiah @Databean @jmacnak @jemoreira Could anyone approve this PR? According to the list of code owners, I think small fix on README.md located at top dir requires additional reviewers. Thanks!

https://github.com/google/android-cuttlefish/blob/main/.github/CODEOWNERS

@0405ysj 0405ysj merged commit b10076b into google:main Sep 11, 2024
11 checks passed
@0405ysj
Copy link
Collaborator Author

0405ysj commented Sep 11, 2024

Thanks!

@0405ysj 0405ysj deleted the docker_workflow branch September 11, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Databean Databean Databean approved these changes

@ikicha ikicha ikicha approved these changes

@ser-io ser-io ser-io approved these changes

@jemoreira jemoreira Awaiting requested review from jemoreira jemoreira is a code owner

@rmuthiah rmuthiah Awaiting requested review from rmuthiah rmuthiah is a code owner

@jmacnak jmacnak Awaiting requested review from jmacnak jmacnak is a code owner

@adelva1984 adelva1984 Awaiting requested review from adelva1984 adelva1984 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0405ysj @ser-io @Databean @ikicha @GoogleCuttlefishTesterBot