Use /usr/bin/env bash instead of /bin/bash #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdevs23
requested review from
jemoreira,
ikicha,
0405ysj and
Databean
as code owners
0405ysj
requested changes
Sep 11, 2024
There was a problem hiding this comment.
I agree /usr/bin/env bash is better than /bin/bash, but I prefer to have united shebang between all script files under docker/. Could you modify other files as well, such as image-build-bazel-wrapper.sh or guest/run_services.sh?
Also after your modification, I would recommend you to amend commit with forced push due to our branch maintenance strategy. Thanks for the contribution!
xdevs23
requested review from
ser-io,
rmuthiah,
jmacnak and
adelva1984
as code owners
|
Sure. I force-pushed and also rebased on top of main. There is one change in a C++ file that appears to be generating a script, so make sure that is correct, as I don't have sufficient knowledge about that specific instance to know whether it's correct. |
0405ysj
approved these changes
Sep 13, 2024
0405ysj
changed the title
Databean
approved these changes
Oct 14, 2024
It's more universally supported and makes the scripts run on NixOS
ser-io
approved these changes
Oct 14, 2024
Databean
added
kokoro:run
GoogleCuttlefishTesterBot
removed
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more universally supported and makes the script run on NixOS