Ensure type names in AutoOneOf generated code are qualified if needed. #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
If the parent class has a nested type called `String` or `Object` then that is what plain `String` or `Object` in the generated code will refer to. That's pretty unlikely to happen, but we should still handle it properly. The use of backticks in the template means that the fully-qualified name will be used if necessary. RELNOTES=n/a PiperOrigin-RevId: 660047188
copybara-service
bot
force-pushed
the
test_main_658406410
branch
from
7d92c59
to
fe6b5c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure type names in AutoOneOf generated code are qualified if needed.
If the parent class has a nested type called
StringorObjectthen that iswhat plain
StringorObjectin the generated code will refer to. That'spretty unlikely to happen, but we should still handle it properly. The use of
backticks in the template means that the fully-qualified name will be used if
necessary.
RELNOTES=n/a