Really produce only a warning for setters with boxed primitive types for primitive properties. #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_main_670709300
branch
from
e266b6a
to
a5339fb
Compare
…for primitive properties.
We'd attempted this in cl/659352853, but we ended up reporting a warning and then failing with an error on a later step instead.
With the new test, we see an error until we make the prod change that I've included:
```
Compilation produced the following diagnostics:
foo/bar/Baz.java:11: warning: [AutoValueUnnecessaryBoxing] property method foo.bar.Baz.blam() is primitive but parameter of setter method is not
Builder blam(Integer x);
^
foo/bar/Baz.java:10: error: [AutoValueBuilderMissingMethod] Expected a method with this signature: foo.bar.Baz.Builder blam(int), or a blamBuilder() method
public interface Builder {
^
```
RELNOTES=n/a
PiperOrigin-RevId: 670953681
copybara-service
bot
force-pushed
the
test_main_670709300
branch
from
a5339fb
to
132a1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really produce only a warning for setters with boxed primitive types for primitive properties.
We'd attempted this in cl/659352853, but we ended up reporting a warning and then failing with an error on a later step instead.
With the new test, we see an error until we make the prod change that I've included:
RELNOTES=n/a