Static methods, and deconflict various namespaces #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for many things which currently fail, but will be addressed in subsequent commits in this PR: * Passing unique_ptrs through our generated C++. * Conflicting function names between namespaces. * It enables the pre-existing static function test.
Previously this didn't work as we stripped off the parameterization of the std::unique_ptr, and we also didn't know we needed to use std::move.
This is a significant set of interrelated changes. The main goals are: * Support static member functions * Handle conflicting function and method names correctly. Identifying static member functions is a bit awkward as it requires us to hold off on converting a given ForeignFn until we've looked in subsequent impl blocks that are generated by bindgen. Otherwise, this is relatively straightforward. Deconflicting names is more complex. See the comment in bridge_name_tracker.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.
Also fixes a problem where we didn't allow
std::unique_ptrto be passed through function shims we generate, and fixes various problems which occurred with name conflicts.