Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pylint.yml #1039

Merged
merged 8 commits into from
Sep 9, 2020
Merged

Create pylint.yml #1039

merged 8 commits into from
Sep 9, 2020

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Sep 8, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 8, 2020
@dmah42
Copy link
Member Author

dmah42 commented Sep 8, 2020

with the latest version, this only fails on "fatal" issues. we should add --error-fail to pylint-exit to fail on errors too but we're not error clean.

@dmah42 dmah42 marked this pull request as ready for review September 9, 2020 08:43
@dmah42 dmah42 merged commit beb360d into master Sep 9, 2020
@dmah42 dmah42 deleted the pylint-action branch September 10, 2020 08:43
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Sep 11, 2020
* Create pylint.yml

* improve file matching

* fix some pylint issues

* run on PR and push (force on master only)

* more pylint fixes

* suppress noisy exit code and filter to fatals

* add conan as a dep so the module is importable

* fix lint error on unreachable branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants