-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind benchmark builder to Python #1040
Conversation
Ok, so indeed I cannot run Python in multiple thread without acquiring the GIL.
Anyways, seems to be out of scope for this issue |
We should probably update the |
I rebased on |
|
||
self.spawn(bazel_argv) | ||
self.spawn(bazel_argv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i fixed this same issue in #1041 :)
well spotted!
LGTM but i'll wait a while in case there's any issues raised. |
The following PR Close #1038
TimeUnit
andBigO
internal::Benchmark
RegisterBenchmark
to return the benchmark objectinternal::Benchmark
option
to use theBenchmark
options.Example
Todo
the multi-threaded benchmark is currently segfaulting and needs to be fixed