Add support for bzlmod (excluding Python bindings) #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Jun 23, 2023
dmah42
approved these changes
Jun 23, 2023
|
is there anything we need to do with the github action bots? |
|
Sorry for the delay, was ooo for the last days. Good point about the github actions. I think we should at least have a single environment in which we run with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of migrating google_benchmark to support bzlmod, the new module dependency management system. This part of the migration focuses on migrating all targets in //:all, //tools:all. It excludes the //bindings/.. targets for now, as those are depending on some changes in rules_python.
Overarching issue: bazelbuild/bazel-central-registry#384