-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change nanobind linkage to response file approach on macOS #1638
Conversation
This is blocked by the mentioned Bazel PR. I will check if I can implement this with the linker input suggested in #1636, but I will reopen this when we have a Bazel release supporting the linker input directly on the |
Reopening, as Bazel 6.4.0 was released with the linker response file support merged in. Give me some time to polish this again, I would request a review (hopefully) when I'm set :) |
2fe54cf
to
92dca2f
Compare
This change needs bazelbuild/bazel#18952 to be merged first. Fixes macOS linkage of GBM's nanobind bindings on macOS by supplying a linker response file instead of `-undefined dynamic_lookup`. The latter has since been deprecated on macOS.
92dca2f
to
ec025b4
Compare
Thanks for the merge, rebased on current What's your take on bumping Bazel dependencies? Some of them are quite stale, so I updated a few in this PR (not EDIT: Seems |
i have no concerns about bumping dependencies if they're stale. is this ready for me to re-review? |
yes, all set, GitHub won't let me request an initial review, that's all :) Re: the |
should we go back to windows-2019 or would that not help? what's the timeline for the release? looks like the last one was 2 weeks ago. |
That won't help, it was actually the failure on windows-2019 that made me assume we need latest. Timeline is probably anywhere within this week, cadence seems to be <every 2 weeks. |
New Should be good to go now. |
This change needs bazelbuild/bazel#18952 to be merged first.
Fixes macOS linkage of GBM's nanobind bindings on macOS by supplying a linker response file instead of
-undefined dynamic_lookup
. The latter has since been deprecated on macOS.