[bindings] Add LTO builds on Windows+MSVC #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gates the MSVC switches behind an `@bazel_skylib:selects` statement. This is a first experiment from best guesses and studying the MSVC docs.
|
We should compare the perf numbers from the Python test for this build to those of some of the previous jobs - I read a forum post today about how MSVC LTO can in some cases tank performance. |
dmah42
reviewed
Oct 26, 2023
bindings/python/nanobind.BUILD
Outdated
| @@ -33,6 +44,7 @@ cc_library( | |||
| "include", | |||
| ], | |||
| linkopts = select({ | |||
| ":winplusmsvc": ["/LTGC"], # allows other compilers on Windows than just MSVC. | |||
There was a problem hiding this comment.
so clang on windows takes /LTGC as a parameter?
There was a problem hiding this comment.
Ah sorry, I guess that came from the comment. The :winplusmsvc condition only applies for Windows + MSVC, so for Windows + clang, it falls through to //conditions:default, which is no options.
I can update the comment if it's too misleading.
LebedevRI
changed the title
dmah42
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gates the MSVC switches behind an
@bazel_skylib:selectsstatement.This is a first experiment from best guesses and studying the MSVC docs.