fix: immediately render for JavaFX #7502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7444
Proposed Changes
Makes it so that JavaFX always immediately rerenders blocks.
Reason for Changes
JavaFX doesn't handle
requestAnimationFrameproperly. It draws the frame before callbacks have completed, so we get glitchy jumpy looking blockly.This change makes it so that JavaFX doesn't use
requestAnimationFramegetting rid of the glitchiness. With this, we also sacrifice the performance improvements provided by the render management system.Test Coverage
Manually tested that this works with the reproduction sample provided in #7444.
Also manually tested that normal in-browser code still uses queueing. (userAgent is working properly)
Documentation
N/A
Additional Information
N/A