-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: widget positioning #7507
Merged
Merged
fix: widget positioning #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self to ping code.org people about this re: their flyout field if it gets approved. I think they can use this new callback to handle the width of their field less jankily. (Since we call |
BeksOmega
commented
Oct 18, 2023
BeksOmega
commented
Oct 18, 2023
maribethb
reviewed
Oct 25, 2023
maribethb
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7491
Proposed Changes
Reorganizes a bunch of code, and makes it so that fields get
onLocationChange
call backs.Reason for Changes
Makes it so that fields can reposition their widgets properly.
Test Coverage
old-dragging.txt
new-dragging.txt
Documentation
N/A
Additional Information
Might want to hold until after release?
Deprecations