Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widget positioning #7507

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Sep 21, 2023

The basics

The details

Resolves

Fixes #7491

Proposed Changes

Reorganizes a bunch of code, and makes it so that fields get onLocationChange call backs.

Reason for Changes

Makes it so that fields can reposition their widgets properly.

Test Coverage

old-dragging.txt
new-dragging.txt

Documentation

N/A

Additional Information

Might want to hold until after release?

Deprecations

  • TODO

@BeksOmega BeksOmega requested a review from maribethb September 21, 2023 20:02
@BeksOmega BeksOmega requested a review from a team as a code owner September 21, 2023 20:02
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Sep 21, 2023
@BeksOmega
Copy link
Collaborator Author

Note to self to ping code.org people about this re: their flyout field if it gets approved. I think they can use this new callback to handle the width of their field less jankily. (Since we call onLocationChange after every render.)

core/block_dragger.ts Outdated Show resolved Hide resolved
core/field_input.ts Outdated Show resolved Hide resolved
core/block_dragger.ts Outdated Show resolved Hide resolved
core/block_dragger.ts Show resolved Hide resolved
core/block_svg.ts Show resolved Hide resolved
core/field_input.ts Show resolved Hide resolved
@BeksOmega BeksOmega merged commit 7d2c307 into google:develop Oct 26, 2023
7 checks passed
@BeksOmega BeksOmega deleted the fix/widget-positioning branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying the structure of a block does not trigger widgets to be repositioned
2 participants