fix: update types in 'field_input.ts' file #7514
Conversation
Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>
Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
|
I've signed the CLA after creating the PR. 😅 |
There was a problem hiding this comment.
Sorry about that! Looks like our issue instructions were slightly incorrect. I should have double checked.
Left comments below about what changes this needs! Thank you for all your work on this :D If it's still running into issues feel free to message me on slack!
core/field_input.ts
Outdated
| @@ -358,7 +358,7 @@ export abstract class FieldInput<T extends InputTypes> extends Field< | |||
| throw new UnattachedFieldError(); | |||
| } | |||
| WidgetDiv.show(this, block.RTL, this.widgetDispose_.bind(this)); | |||
| this.htmlInput_ = this.widgetCreate_() as HTMLInputElement; | |||
There was a problem hiding this comment.
This cast is actually still necessary =) So if you could put it back that'd be great!
There was a problem hiding this comment.
Okay, will just do that!
core/field_input.ts
Outdated
| @@ -375,7 +375,7 @@ export abstract class FieldInput<T extends InputTypes> extends Field< | |||
| * | |||
| * @returns The newly created text input editor. | |||
| */ | |||
| protected widgetCreate_(): HTMLElement { | |||
| protected widgetCreate_(): HTMLInputElement { | |||
There was a problem hiding this comment.
This should be HTMLInputElement | HTMLTextAreaElement
BeksOmega
requested review from
BeksOmega
and removed request for
maribethb
Signed-off-by: Akanksha Kushwaha <cmakanksha@gmail.com>
|
hey I am Fiona, glad to join the group! Could you pls assign me some tasks? |
maribethb
changed the title
The basics
The details
Resolves
Fixes #7253
Proposed Changes
Update the
field_input.tsfile with the following changes:HTMLElementtoHTMLInputElementfor widgetCreate_as HTMLInputElementcast in showInlineEditor.Reason for Changes
Returning proper type info for input-specific manipulations of the element.
Test Coverage
Documentation
Additional Information