-
Notifications
You must be signed in to change notification settings - Fork 757
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return SSL_ERROR_SYSCALL on unclean EOF.
This regressed in fcf2583. 0 return code on unclean shutdown means the underlying BIO returned EOF, didn't push any error code, but we haven't seen close_notify yet. The intent seems to be that you go check errno or some BIO-specific equivalent if you care about close_notify. Make sure test code routes all SSL_read return codes through SSL_get_error since that's supposed to work in all cases. (Note that rv == 0 can still give SSL_ERROR_SSL if the error queue is not empty.) Change-Id: I45bf9614573f876d93419ce169a4e0d9ceea9052 Reviewed-on: https://boringssl-review.googlesource.com/2981 Reviewed-by: Adam Langley <agl@google.com>
- Loading branch information
Showing
2 changed files
with
42 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters