Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASHA audio status point #148

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add ASHA audio status point #148

merged 1 commit into from
Mar 23, 2023

Conversation

yuyangh
Copy link
Collaborator

@yuyangh yuyangh commented Mar 21, 2023

No description provided.

barbibulle
barbibulle approved these changes Mar 21, 2023
View reviewed changes
bumble/profiles/asha_service.py Outdated
# force=True))
# OPCODE_STATUS does not need audio status point update
if opcode != AshaService.OPCODE_STATUS:
asyncio.create_task(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out in PR #147 by @uael , there's a risk that the task may be garbage-collected when you don't keep a reference to it. You could use AsyncRunner.run() instead of asyncio.create_task() (when PR #147 is merged) to get around the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • AsynRunner.spawn()

@yuyangh yuyangh force-pushed the yuyangh/add_audio_status_point branch from 62e9f00 to de5a710 Compare March 23, 2023 19:11
@yuyangh yuyangh force-pushed the yuyangh/add_audio_status_point branch from de5a710 to 9541cb6 Compare March 23, 2023 19:15
@uael uael merged commit 7ae1bf8 into google:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uael uael uael left review comments

@barbibulle barbibulle barbibulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyangh @barbibulle @uael