Handle the new 5.0 linux format for oom messages #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dashpole i've reviewed this. LGTM |
|
Merging based on lgtm above. |
kgtw
added a commit
to kgtw/cadvisor
that referenced
this pull request
Mar 1, 2021
…ntroduced in google#2418 Signed-off-by: Kris Gambirazzi <kris.gambirazzi@transferwise.com>
iwankgb
pushed a commit
to iwankgb/cadvisor
that referenced
this pull request
Mar 10, 2021
…ntroduced in google#2418 Signed-off-by: Kris Gambirazzi <kris.gambirazzi@transferwise.com>
iwankgb
pushed a commit
to iwankgb/cadvisor
that referenced
this pull request
Mar 10, 2021
…ntroduced in google#2418 Signed-off-by: Kris Gambirazzi <kris.gambirazzi@transferwise.com>
dqminh
pushed a commit
to dqminh/cadvisor
that referenced
this pull request
Oct 18, 2021
…ntroduced in google#2418 Signed-off-by: Kris Gambirazzi <kris.gambirazzi@transferwise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2417, which caused all OOMs on >5.0 kernels to be considered system ooms.
This adds parsing for the new format. When this format is found, we can "finish" immediately, since the message has all of the information we want in a single place. If the format is not found, we fall back to looking for the old message. It also grabs the Constraint that is hit, which may be useful for users that have topology constraints.