Add libipmctl to the docker image.

[Creatone]

This PR adds libipmctl to the docker image.

[k8s-ci-robot]

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[katarzyna-z]

#2676 should be merged with this pull request without these changes it is not possible to run docker container on machine without non-volatile memory

[katarzyna-z]

ndctl should be enough, development files are not needed to run cAdvisor with libipmctl

[bobbypage]

is this still correct? is ndctl enough or is ndctl-dev needed?

[Creatone]

Unfortunately not

[iwankgb]

@Creatone can you visit https://git.k8s.io/community/community-membership.md#member? You will not need ok-to-test anymore.

[iwankgb]

/ok-to-test

[Creatone]

@Creatone can you visit https://git.k8s.io/community/community-membership.md#member? You will not need ok-to-test anymore.

Thanks, I'll try after my holiday.

[iwankgb]

@bobbypage this is another PR that is relatively straightforward and could be merged.

[Creatone]

@bobbypage Can you look at this? Nice to have this in docker :)

[bobbypage]

Thanks for adding this. One question I have -- my understanding is that libipmctl is not required for cadvisor, libipmctl is needed to get info about Optane Persistent Memory.

By adding it to the main dockerfile, it means the Docker image will always include libipmctl, and cadvisor will be built with it (i.e. GO_FLAGS). Is there any issue always including libipmctl and building cadvisor against it in the docker image? What happens if the underlying system doesn't support ipmctl?

[Creatone]

@bobbypage after #2723 , no :)

If the underlying system doesn't support ipmctl, it would print a warning and continue working.

[Creatone]

@bobbypage

[bobbypage]

Thanks for change @Creatone .

I tested it out and it seemed to build fine at the end but I got some suspicious errors and warnings, e.g.

make[1]: [Makefile:401: install] Error 1 (ignored)

See full build log here: https://gist.github.com/bobbypage/dbc5f966e44db6336c7ebf94f9da706a

Are those errors / compiler warnings expected?

[Creatone]

This is related to libpfm dependency. I'll investigate this separately.

[bobbypage]

Thanks @Creatone, can you rebase and repush to trigger CI again, looks like it's stuck in a weird state.

[Creatone]

@bobbypage Done

[bobbypage]

LGTM, thanks!