-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mount library dependency from utils/mount to mount-utils #2687
Conversation
Hi @brahmaroutu. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@brahmaroutu, I had no idea that I can use commands here. |
lgtm |
@brahmaroutu I do not have all the superpowers, though. I can't merge it :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@brahmaroutu we can't actually depend on a staging library in cAdvisor since cAdvisor is vendored into the kubelet. This will have to be reverted. |
This PR is updating the dependency for the mount library. We have recently moved utils/mount to mount-utils under the repo https://github.com/kubernetes/mount-utils. This library is now available for kubernetes/kubernetes components under staging/src/k8s.io/mount-utils. Go module being k8s.io/mount-utils
Going forward, mount library will not be maintained under the repo https://github.com/kubernetes/utils.