update docker client method

[JornShen]

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

dockerclient.NewClient has been deprecated. And change to recommended public methods dockerclient.NewClientWithOpts.

using WithAPIVersionNegotiation() makes the Docker client negotiate down to a lower version if Docker's current API version is newer than the server version.

ref: kubelet: pod metrics not visible with Docker 18 (19.03 works)

After kubernetes/kubernetes#89687 merged(docker client dependency update to newer), We find that kubelet failed to register cadvisor docker factory when we use k8s v1.19 with docker 18.X. And info as fellow:

[factory.go:161] Registration of the docker container factory failed: failed to validate Docker info: failed to detect Docker info: Error response from daemon: client version 1.40 is too new. Maximum supported API version is 1.39

The error Registration of the docker container factory is from

cadvisor/container/factory.go

Lines 160 to 163 in 0f8972f

	for name, plugin := range plugins {
	watcher, err := plugin.Register(factory, fsInfo, includedMetrics)
	if err != nil {
	klog.V(5).Infof("Registration of the %s container factory failed: %v", name, err)

the error failed to validate is from

cadvisor/container/docker/docker.go

Lines 124 to 127 in 0f8972f

	dockerInfo, err := client.Info(defaultContext())
	if err != nil {
	return nil, fmt.Errorf("failed to detect Docker info: %v", err)
	}

we find in advisor, docker client is created by Client(). And it seems no negotiating to old server version if we use deprecated NewClient with higher docker client version.

cadvisor/container/docker/client.go

Lines 55 to 58 in 0f8972f

	dockerClient, dockerClientErr = dclient.NewClient(*ArgDockerEndpoint,
	"",
	client,
	nil)

what does this PR do:
update dockerclient.NewClient to dockerclient.NewClientWithOpts
and enable client negotiate down to a lower version server version.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[k8s-ci-robot]

Hi @JornShen. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JornShen]

cc @dims

[dims]

cc @bobbypage

LGTM!

[JornShen]

@googlebot I signed it!

[bobbypage]

Thanks for the fix, LGTM!

[bobbypage]

/ok-to-test